Merged
Conversation
octonato
commented
Jul 19, 2021
Comment on lines
+30
to
+31
| sed -i .versionsBackup "s/<akkaserverless-sdk.version>\(.*\)<\/akkaserverless-sdk.version>/<akkaserverless-sdk.version>$SDK_VERSION<\/akkaserverless-sdk.version>/" $i/pom.xml | ||
| rm $i/pom.xml.versionsBackup |
Member
Author
There was a problem hiding this comment.
According to sed docs, one could omit the extension when using -i, but it didn't work for me.
Also, the recommended usage is to create a backup file. We don't really need it, so I delete it as soon as we know that the file was written.
raboof
approved these changes
Jul 20, 2021
Contributor
raboof
left a comment
raboof
left a comment
There was a problem hiding this comment.
You know I like it ;) - thanks!
Member
Author
Of course I know it. I did it for you. 😄 |
franciscolopezsancho
pushed a commit
to franciscolopezsancho/kalix-jvm-sdk
that referenced
this pull request
Jul 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updatePomVerions.shusesedto updateakkaserverless-sdk.versionproperty